[3.14] gh-138804: Check type in shlex.quote (GH-138809)
#138846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 220c0a8) Co-authored-by: Christoph Walcher <[email protected]>
This was referenced Sep 12, 2025
ZeroIntensity
approved these changes
Sep 12, 2025
picnixz
approved these changes
Sep 13, 2025
There was a problem hiding this comment.
@ZeroIntensity AFAIK, your approval on an automated backport is sufficient for the RM.
|
I thought Hugo said that it wasn't. |
|
The devguide says:
So for example, if Miss Islington opens a backport of your PR, then your approval on the backport doesn't count as peer review -- you're reviewing your own change. But you can approve a backport from someone else. In this case, @ZeroIntensity's approval of wiomoc's PR is good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 220c0a8)
Co-authored-by: Christoph Walcher [email protected]